Inspection of "Merge pull request #188 from marpal71/fixCustomerA..." - Laracommerce/laracom - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d34773...19d81e )

by Jeff

created 2019-05-14 21:49 UTC

Status

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -141,13 +141,13 @@
 block discarded – undo
     {
         $address = $this->addressRepo->findCustomerAddressById($addressId, auth()->user());
 
-       if ($address->orders()->exists()) {
-             $address->status=0;
-             $address->save();
-       }
-       else {
-             $address->delete();
-       }
+        if ($address->orders()->exists()) {
+                $address->status=0;
+                $address->save();
+        }
+        else {
+                $address->delete();
+        }
         return redirect()->route('accounts', ['tab' => 'address'])
             ->with('message', 'Address delete successful');
     }

Please login to merge, or discard this patch.

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -144,8 +144,7 @@
 block discarded – undo
        if ($address->orders()->exists()) {
              $address->status=0;
              $address->save();
-       }
-       else {
+       } else {
              $address->delete();
        }
         return redirect()->route('accounts', ['tab' => 'address'])

Please login to merge, or discard this patch.

		@@ -144,8 +144,7 @@
		block discarded – undo
144	144	if ($address->orders()->exists()) {
145	145	$address->status=0;
146	146	$address->save();
147		- }
148		- else {
	147	+ } else {
149	148	$address->delete();
150	149	}
151	150	return redirect()->route('accounts', ['tab' => 'address'])

		@@ -141,13 +141,13 @@
		block discarded – undo
141	141	{
142	142	$address = $this->addressRepo->findCustomerAddressById($addressId, auth()->user());
143	143
144		- if ($address->orders()->exists()) {
145		- $address->status=0;
146		- $address->save();
147		- }
148		- else {
149		- $address->delete();
150		- }
	144	+ if ($address->orders()->exists()) {
	145	+ $address->status=0;
	146	+ $address->save();
	147	+ }
	148	+ else {
	149	+ $address->delete();
	150	+ }
151	151	return redirect()->route('accounts', ['tab' => 'address'])
152	152	->with('message', 'Address delete successful');
153	153	}

Laracommerce / laracom

Push — master ( d34773...19d81e )

Status

Category

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch